Fix types in JSDoc #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szepeviktor
commented
Dec 1, 2024
| @@ -4,7 +4,6 @@ export default class Cookie | |||
| * Make a new Cookie instance. | |||
| * | |||
| * @param {string} namespace | |||
| * @return {void} | |||
There was a problem hiding this comment.
No return tag for constructor.
szepeviktor
commented
Dec 1, 2024
Comment on lines
-46
to
+49
| * @param {mixed} value | ||
| * @return {mixed} | ||
| * @param {*} value | ||
| * @return {*} |
There was a problem hiding this comment.
PHP: mixed
JS: *
szepeviktor
commented
Dec 1, 2024
Comment on lines
-81
to
+83
| this.set(key, null, 'Thu, 01 Jan 1970 00:00:01 GMT'); | ||
| this.set(key, '', 'Thu, 01 Jan 1970 00:00:01 GMT'); |
There was a problem hiding this comment.
null is not compatible with string
szepeviktor
commented
Dec 1, 2024
Comment on lines
+36
to
+37
| /** @type {string[]} */ | ||
| const initialValue = []; |
There was a problem hiding this comment.
This sets the type for the empty array.
|
@adamlaki This is not a business PR but a scientific PR 👺 |
|
@adamlaki This is black tar. ⚫ We should close it. |
|
@iamgergo Gergő, please take a look at this, too! |
|
@szepeviktor Can you resolve the conflicts please? |
|
Done 🍏 This is not really a PR but won't do much damage. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tsconfig.json{ "compilerOptions": { "target": "es2017", "module": "es6", "allowJs": true, "checkJs": true, "noEmit": true, "esModuleInterop": true, "forceConsistentCasingInFileNames": true, "strict": true, "skipLibCheck": true } }